Create fade in/fade out transitions for nested fragments in History Page

This patch adds the fade-in/fade-out transition to subpages on the History page

Comment on attachment 782055 [details] [diff] [review] animationfrags.diff Review of attachment 782055 [details] [diff] [review]: ----------------------------------------------------------------- Looks fine otherwise. ::: mobile/android/base/home/HistoryPage.java @@ +77,5 @@ > } > > private void showSubPage(Fragment subPage) { > getChildFragmentManager().beginTransaction() > + .setCustomAnimations(R.anim.fade_in, R.anim.fade_out) You should probably use Android's predefined fade in/out animations instead. IIRC, android.R.anim.fade_in and android.R.anim.fade_out respectively.

The patch does as mentioned above

Comment on attachment 783990 [details] [diff] [review] Patch: Animate transitions using android anims Review of attachment 783990 [details] [diff] [review]: ----------------------------------------------------------------- ::: mobile/android/base/home/HistoryPage.java @@ +7,5 @@ > > import org.mozilla.gecko.R; > import org.mozilla.gecko.widget.IconTabWidget; > + > +import android.R.anim; Do you actually need this import?

Comment on attachment 783990 [details] [diff] [review] Patch: Animate transitions using android anims Tried this patch locally. The cross-fading is too slow. Also, we probably want to avoid fading in when the first page is initially presented. Flipping the review flag just to be clear about the status of this bug.

Closing as INCOMPLETE