Closed
Bug 897689
Opened 12 years ago
Closed 12 years ago
[fig] "Open in Reader" context menu item is never shown
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 26
People
(Reporter: Margaret, Assigned: lucasr)
References
Details
(Whiteboard: fixed-fig, abouthome-hackathon)
Attachments
(1 file)
3.88 KB,
patch
|
Margaret
:
review+
|
Details | Diff | Splinter Review |
On m-c, it looks like we just make it visible for reader mode item in AllPagesTab:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/awesomebar/AllPagesTab.java#775
What do we want to do for the new about:home? Do we still want this menuitem?
I think we need to do a pass through the context menus for the new about:home to make sure we have all the right context menu items where we want them.
Flags: needinfo?(ibarlow)
Comment 1•12 years ago
|
||
For pages in the Reading List, we should just automatically open them in Reader Mode, so no real need for a context menu item.
If we have already determined whether pages listed elsewhere on about:home (History, Bookmarks) can be opened in Reader Mode, a context menu item would be nice. But I'm pretty sure we aren't doing that right now, which is why we removed it a while back.
Flags: needinfo?(ibarlow)
Assignee | ||
Updated•12 years ago
|
Whiteboard: abouthome-hackathon
Assignee | ||
Comment 2•12 years ago
|
||
The current behaviour is that we show the 'Open in Reader' context menu item when an item of the reading list shows up in the awesomescreen search results. That means we should only show 'Open in Reader' for search and visited items.
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → lucasr.at.mozilla
Assignee | ||
Comment 3•12 years ago
|
||
Attachment #781014 -
Flags: review?(margaret.leibovic)
Reporter | ||
Comment 4•12 years ago
|
||
Comment on attachment 781014 [details] [diff] [review]
Restore "Open in Reader" context menu item in about:home
Review of attachment 781014 [details] [diff] [review]:
-----------------------------------------------------------------
You're going to bitrot me in bug 897250, but I forgive you :)
Attachment #781014 -
Flags: review?(margaret.leibovic) → review+
Assignee | ||
Comment 5•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Whiteboard: abouthome-hackathon → fixed-fig, abouthome-hackathon
Comment 6•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•