In Italian we have a very long localization for the footer string "You can always change your add-ons by going to the Add-ons Manager." (footer.label in /chrome/mozapps/extensions/selectAddons.dtd). In the second page of the wizard this string is displayed with two buttons ("Back" and "Done"), so in order to fit all elements we have a very wide window (128ch vs 93ch in en-US). If this string could wrap on two lines and leave enough space for the buttons, we could use a much narrower window.

This is stupid.

> This is stupid. Care to explain?

(In reply to flod (Francesco Lodolo) from comment #3) > Care to explain? Sorry, I meant that the way labels work with wrapping is stupid. You're meant to be able to just add text as a child element to make it wrap (as opposed to using the value attribute). Which is what the code already does - so it was *meant* to wrap already :\

I've noticed too that wrapping does not occur without the flex, though it could depend on the container. Why label and not description? I guess they do the same thing when used like this.

(In reply to Brian King (Briks) [:kinger] from comment #5) > Why label and not description? I guess they do the same thing when used like > this. I considered changing it, but ultimately decided it was unnecessary code change. AFAIK there's no functional difference when using it like this - just semantic difference in the code. (Someone correct me if I'm wrong, but I don't think they're exposed differently to accessibility APIs.)

Comment on attachment 554319 [details] [diff] [review] Patch v1 Review of attachment 554319 [details] [diff] [review]: ----------------------------------------------------------------- XUL!

This looks like something we would want to take on aurora as well?

Comment on attachment 554319 [details] [diff] [review] Patch v1 (In reply to Axel Hecht [:Pike] from comment #10) > This looks like something we would want to take on aurora as well? I think so. Minimal risk.

Comment on attachment 554319 [details] [diff] [review] Patch v1 Approved for Aurora (Update 8.) Please land it as soon as possible. Thanks!

It's enough to update from Aurora 8.0a2 to 9.0a2 and the same thing for nightly in order to verify this? How can I verify this on beta? Thanks

(In reply to Vlad [QA] from comment #14) > It's enough to update from Aurora 8.0a2 to 9.0a2 and the same thing for > nightly in order to verify this? How can I verify this on beta? > Thanks Upgrading from Fireflx 7 to Firefox 8b should show the UI, doing so in an affected locale (like Italian) would probably be the best test.

I have followed the advice from comment15 in order to verify this bug. I've upgraded from Firefox 7b6 to Firefox 8b2 and with the it locale I get a more wider window but the text in the second window (the one with two buttons: back and done) is wrapped on two lines. The same is on the en-us locale. Is this intended? Thanks

(In reply to Vlad [QA] from comment #16) > is wrapped on two lines. Yep, this fix was to make that wrap.

qa+ for verification in Firefox 8.

Actually, I think we can mark this verified based on comment 17 and comment 16.