When sorting by name, there are a ton of nameless add-ons: https://preview.addons.mozilla.org/z/en-US/firefox/extensions/?sort=name&unreviewed=on We should not show these. I don't think we do in Remora (the same sort doesn't show them there)

I don't think these are nameless: https://preview.addons.mozilla.org/en-US/firefox/addon/160845/ has a only 'de' translation of it's name, but we don't pull that through. Hope we don't take a huge performance hit for the fix.

If it doesn't have an English name and you're looking at en-US, we shouldn't be showing the add-on, right?

One of the add-ons I looked at had a translation with locale=zh-tw and english text in the string, and the default locale was en-US. So the default locale didn't have a row in the trans table. It's bad data.

We should fix this before pushing these pages live -- it's a regression from Remora and makes the Name sort (the most popular one) pretty worthless.

When the add-ons are sorted by "name" we show 8638(including unreviewed)as opposed to other sorts where we show 8757 add-ons.That's a difference of 119 add-ons just based on your sort option. Fligtar,are you okay with this?

We shouldn't show nameless add-ons anywhere, regardless of sort. Unless those 119 add-ons are showing up in other sorts, sounds like a separate issue.

(In reply to comment #7) > We shouldn't show nameless add-ons anywhere, regardless of sort. Unless those > 119 add-ons are showing up in other sorts, sounds like a separate issue. We show the nameless add-ons in other sorts.Reopening.

We should add a cron that checks the name and valid version and other vagaries and drops a boolean in something like addons.ready_for_battle.

Rules: - If an add-on doesn't have a name in the locale you're browsing in, we show the add-on info in the add-on's default locale If there are blanks outside of that, those are other bugs and things we should fix. So, this shouldn't be "omit nameless add-ons" so much as "show default locales for add-ons without current locale"

(In reply to comment #10) > If there are blanks outside of that, those are other bugs and things we should > fix. So, this shouldn't be "omit nameless add-ons" so much as "show default > locales for add-ons without current locale" We're already doing the right thing with the default locale in queries.