User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:136.0) Gecko/20100101 Firefox/136.0

Steps to reproduce:

1. go (in private window if you want) to login.microsoftonline.com (possibly other sites also, just spotted on this one)
2. open developer tools (right click-inspect)
3. go to storage - cookies - right click - delete all cookies

Actual results:

Some session cookies are not deleted and stay there. Tested in Firefox 135 and 136 (currently in beta just to test, 135 stable has same behavior). You can still delete all cookies from Settings - Manage Data.

Expected results:

All cookies were deleted previously from developer tools.

The Bugbug bot thinks this bug should belong to the 'DevTools::Storage Inspector' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Indeed, used to work with ESR, Nicolas will take a look

This was regressed by Bug 1907570 , I'll have a look

Thanks! Confirming + P2/S3 since this is a recent regression/

The _removeCookies method had its own (faulty) host matching function,
which was buggy for cookies with domain.
The class already has a isCookieAtHost method, which doesn't have
the faulty check, so we use this instead.
A test case is added in browser_storage_cookies_delete_all.js.

Set release status flags based on info from the regressing bug 1907570

Backed out for causing dt failures in /browser_storage_delete.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/245390cac1b67b56860e8c69b203a4be7c06550a

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=8eadda1ece0505c71838f75d83dec12f5625d69a

Failure log: https://treeherder.mozilla.org/logviewer?job_id=494998834&repo=autoland&lineNumber=3756

the cleanup function was only handling the last opened tab and my patch make a test add a second tab. I fixed the cleanup function

https://hg.mozilla.org/mozilla-central/rev/8b385a2d7056

The patch landed in nightly and beta is affected.
:nchevobbe, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox136 to wontfix.

For more information, please visit BugBot documentation.

The _removeCookies method had its own (faulty) host matching function,
which was buggy for cookies with domain.
The class already has a isCookieAtHost method, which doesn't have
the faulty check, so we use this instead.
A test case is added in browser_storage_cookies_delete_all.js.

Adding a new tab in the test revealed that the cleanup function was only
calling window.clear for the last opened tab, so we now do it for all the
tabs we're closing.

Original Revision: https://phabricator.services.mozilla.com/D238012

beta Uplift Approval Request

• User impact if declined: can't delete some cookies from DevTools storage panel
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: -
• Risk associated with taking this patch: low
• Explanation of risk level: DevTools only fix, re-using existing helper, covered by mochitest
• String changes made/needed: -
• Is Android affected?: yes

https://hg.mozilla.org/releases/mozilla-beta/rev/f2baf707bcab7a20e7dc2aaf2e349f197eeb5d6e