Closed Bug 1944981 Opened 4 months ago Closed 4 months ago

Expose a targetType attribute on all target actor forms

Categories

(DevTools :: Framework, enhancement)

enhancement

Tracking

(firefox137 fixed)

RESOLVED FIXED
137 Branch
Tracking Status
firefox137 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

We have something a bit brittle in Target Command to define the targetType for each target front:
https://searchfox.org/mozilla-central/rev/548b6981501f59e3c9f2f7851c013e7d53c4e72f/devtools/shared/commands/target/target-command.js#711-741

It would be nice to convey the existing targetType attribute from server to client so that we can have a simpler and more reliable attribute to distinguish the target types.
This would also be used by VS Code.

This will help distinguish targets by types in the frontend, as well as in Vs Code.

Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/94131cbb3481 [devtools] Expose a targetType attribute on all target actor forms. r=devtools-reviewers,bomsy
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 137 Branch

This will be useful when we start removing the backward compat code.

Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/850d0208daff [devtools] Set targetType on xpcshell test target actors. r=devtools-reviewers,jdescottes

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size:

OSZAR »