Closed Bug 1915848 Opened 9 months ago Closed 8 months ago

Pref off HTTP/2 push

Categories

(Core :: Networking: HTTP, task, P2)

task

Tracking

()

RESOLVED FIXED
132 Branch
Tracking Status
relnote-firefox --- 132+
firefox-esr128 133+ fixed
firefox132 --- fixed

People

(Reporter: valentin, Assigned: valentin)

References

Details

(Keywords: dev-doc-complete, Whiteboard: [necko-triaged])

Attachments

(2 files, 1 obsolete file)

Chrome has removed HTTP/2 push from their browser almost 2 years ago.
https://chromestatus.com/feature/6302414934114304

Recently, we've started seeing some issues that are exclusively related to us supporting HTTP/2 push - See bug 1915830 for a list of such issues, as well as other known bugs in our implementation. It also caused an incident in bug 1909271 when we tried to ship Extensible Prioritization Scheme for HTTP/2.

In order to avoid future webcompat problems only affecting Firefox, I think we should disable HTTP/2 push.
This bug will track flipping the network.http.http2.allow-push pref to false, with a separate bug to remove the implementation in a few releases if the deprecation goes smoothly.

HTTP/2 Push was involved in several web-compat issues recently.
See bug 1915830 for known H2-push bugs.

As such it's best to turn off the feature and align with Chrome
in order to avoid future push bugs only affecting Firefox.

Assignee: nobody → valentin.gosu
Status: NEW → ASSIGNED
See Also: → 1911741
See Also: → 1913100
Keywords: dev-doc-needed

Backed out for causing xpcshell failure on test_dns_by_type_resolve.js

Backout link

Push with failures

Failure log

Flags: needinfo?(valentin.gosu)
Flags: needinfo?(valentin.gosu)
Flags: needinfo?(valentin.gosu)
See Also: → 1913938
Blocks: 1913938
See Also: 1913938
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 132 Branch
No longer blocks: necko-pref-flips
See Also: → necko-pref-flips

How practical is it to uplift this to help with the webcompat problems?

Flags: needinfo?(valentin.gosu)

Given that we've had a minor regression, I'd rather it ride the trains.
Unless we also want to uplift bug 1915134 with it?

Flags: needinfo?(valentin.gosu) → needinfo?(jmuizelaar)
See Also: → 1918458

[Tracking Requested - why for this release]:
This pref is currently riding the trains. We want to let it go to release, and ideally we'd also uplift the patches to the next ESR (128.5).
The patches needing to be uplifted are attachment 9421807 [details], attachment 9421244 [details], attachment 9421245 [details]

The necko team's recommendation is that we let this ride the trains to release.

Flags: needinfo?(jmuizelaar)
Regressions: 1919750

Did you want to nominate this for the Fx132 relnotes? Please go ahead and do so if yes.

Flags: needinfo?(valentin.gosu)

Release Note Request (optional, but appreciated)
[Why is this notable]: HTTP/2 Push support was disabled.
[Affects Firefox for Android]: Yes
[Suggested wording]: We disabled HTTP/2 Push due to it causing webcompatibility issues. This feature is not currently supported by any other major browser.
[Links (documentation, blog post, etc)]:
Intent to unship: https://groups.google.com/a/mozilla.org/g/dev-platform/c/vU9hJg343U8/m/4cZsHz7TAQAJ

relnote-firefox: --- → ?
Flags: needinfo?(valentin.gosu)

Added to the Fx132 relnotes.

MDN docs changes for this can be tracked in the following GitHub issue: https://github.com/mdn/content/issues/36116

:valentin next week is the final week before esr128.5 goes to build.
Is this ready for an esr128 uplift request?

Flags: needinfo?(valentin.gosu)

HTTP/2 Push was involved in several web-compat issues recently.
See bug 1915830 for known H2-push bugs.

As such it's best to turn off the feature and align with Chrome
in order to avoid future push bugs only affecting Firefox.

Original Revision: https://phabricator.services.mozilla.com/D220699

Attachment #9436352 - Flags: approval-mozilla-esr128?
Attachment #9436352 - Attachment is obsolete: true
Attachment #9436352 - Flags: approval-mozilla-esr128?

HTTP/2 Push was involved in several web-compat issues recently.
See bug 1915830 for known H2-push bugs.

As such it's best to turn off the feature and align with Chrome
in order to avoid future push bugs only affecting Firefox.

Original Revision: https://phabricator.services.mozilla.com/D220699

Attachment #9436362 - Flags: approval-mozilla-esr128?

I've requested uplift for all three patches.

Flags: needinfo?(valentin.gosu)

:valentin, the request is missing an Uplift Request form.
You can add it by selecting the Change Uplift Request form action

Flags: needinfo?(valentin.gosu)

Removing NI, I was just looking at this patch in isolation. I see it's part of a stack that includes an uplift form.

Flags: needinfo?(valentin.gosu)
Blocks: 1911741
See Also: 1911741
Attachment #9436362 - Flags: approval-mozilla-esr128? → approval-mozilla-esr128+
Blocks: 1913100
See Also: 1913100
Regressions: 1933747
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size:

OSZAR »