Support EXTRA_IS_SENSITIVE for clipboard
Categories
(GeckoView :: General, enhancement, P3)
Tracking
(relnote-firefox 133+, firefox133 fixed)
People
(Reporter: m_kato, Assigned: m_kato)
References
Details
(Whiteboard: [geckoview:2022h2?])
Attachments
(2 files)
4.11 KB,
patch
|
Details | Diff | Splinter Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review |
If nsITransferable.isPrivate
is true, we may have to set EXTRA_IS_SENSITIVE
when copying text to clipboard.
Comment 1•3 years ago
|
||
We should set EXTRA_IS_SENSITIVE
for password or credit card data copied to the clipboard.
Assignee | ||
Updated•7 months ago
|
Assignee | ||
Comment 3•7 months ago
|
||
Unfortunately, Android JUnit test runner doesn't often get ClipbDescription.extras
from clipboard service when running test runner. If test runner side fixes this issue, I will land/review this.
Assignee | ||
Updated•7 months ago
|
Assignee | ||
Comment 4•7 months ago
|
||
When nsITransferable.isPrivateData is true, such as coping password or
private mode, we should set EXTRA_IS_SENSITIVE to ClipData.
AndroidJunit test runner doesn't often get ClipDescription.extras
from clipboard service in test runner. So we cannot write a unit test
using AndroidJUnit test runner.
Comment 7•7 months ago
|
||
(In reply to Chris Peterson [:cpeterson] from comment #1)
We should set
EXTRA_IS_SENSITIVE
for password or credit card data copied to the clipboard.
Is there anything user facing worth nominating for a release note? (Process info)
Assignee | ||
Comment 8•7 months ago
|
||
Release Note Request (optional, but appreciated)
[Why is this notable]: When copying a text to clipboard on private browsing mode, Firefox handles it as sensitive context. So toast notification for clipboard is masked.
[Affects Firefox for Android]: Firefox 113
[Suggested wording]: When copying a text to clipboard on private browsing mode, Firefox handles it as sensitive context. So toast notification for clipboard is masked on Android 13 and higher.
[Links (documentation, blog post, etc)]:N/A
Comment 9•6 months ago
|
||
Thanks, added to the beta release notes.
Keeping the relnote-firefox flag as ? to keep it on the radar for inclusion in the final Fx133 release notes.
Updated•6 months ago
|
Comment 10•6 months ago
|
||
Added to the Fx133 release notes.
Available to preview on staging, please allow 30 minutes for the site to update.
Description
•