Closed Bug 1776646 Opened 3 years ago Closed 7 months ago

Support EXTRA_IS_SENSITIVE for clipboard

Categories

(GeckoView :: General, enhancement, P3)

Unspecified
All
enhancement

Tracking

(relnote-firefox 133+, firefox133 fixed)

RESOLVED FIXED
133 Branch
Tracking Status
relnote-firefox --- 133+
firefox133 --- fixed

People

(Reporter: m_kato, Assigned: m_kato)

References

Details

(Whiteboard: [geckoview:2022h2?])

Attachments

(2 files)

https://developer.android.com/about/versions/13/features/copy-paste#sensitive-content

If nsITransferable.isPrivate is true, we may have to set EXTRA_IS_SENSITIVE when copying text to clipboard.

We should set EXTRA_IS_SENSITIVE for password or credit card data copied to the clipboard.

Severity: -- → S3
Priority: -- → P3
Whiteboard: [geckoview:2022h2?]

Tasks and enhancements should have severity N/A.

Severity: S3 → N/A
Assignee: nobody → m_kato

Unfortunately, Android JUnit test runner doesn't often get ClipbDescription.extras from clipboard service when running test runner. If test runner side fixes this issue, I will land/review this.

Attachment #9430334 - Attachment is patch: true

When nsITransferable.isPrivateData is true, such as coping password or
private mode, we should set EXTRA_IS_SENSITIVE to ClipData.

AndroidJunit test runner doesn't often get ClipDescription.extras
from clipboard service in test runner. So we cannot write a unit test
using AndroidJUnit test runner.

Pushed by m_kato@ga2.so-net.ne.jp: https://hg.mozilla.org/integration/autoland/rev/63d7060ba273 Support EXTRA_IS_SENSITIVE for clipboard. r=geckoview-reviewers,owlish
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch

(In reply to Chris Peterson [:cpeterson] from comment #1)

We should set EXTRA_IS_SENSITIVE for password or credit card data copied to the clipboard.

Is there anything user facing worth nominating for a release note? (Process info)

Flags: needinfo?(m_kato)
Flags: needinfo?(cpeterson)

Release Note Request (optional, but appreciated)
[Why is this notable]: When copying a text to clipboard on private browsing mode, Firefox handles it as sensitive context. So toast notification for clipboard is masked.
[Affects Firefox for Android]: Firefox 113
[Suggested wording]: When copying a text to clipboard on private browsing mode, Firefox handles it as sensitive context. So toast notification for clipboard is masked on Android 13 and higher.
[Links (documentation, blog post, etc)]:N/A

relnote-firefox: --- → ?
Flags: needinfo?(m_kato)
Flags: needinfo?(cpeterson)

Thanks, added to the beta release notes.
Keeping the relnote-firefox flag as ? to keep it on the radar for inclusion in the final Fx133 release notes.

Added to the Fx133 release notes.
Available to preview on staging, please allow 30 minutes for the site to update.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size:

OSZAR »