Closed
Bug 1589891
Opened 6 years ago
Closed 6 years ago
Remove unused code from commandglue.js
Categories
(SeaMonkey :: General, task)
SeaMonkey
General
Tracking
(seamonkey2.49esr wontfix, seamonkey2.53 fixed, seamonkey2.57esr fixed)
RESOLVED
FIXED
seamonkey2.69
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
(Whiteboard: SM2.53.1)
Attachments
(1 file, 1 obsolete file)
|
1.93 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
LoadMessageByUri and linked functions appear to be no longer in use.
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: None
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: None
Attachment #9102821 -
Flags: review?(frgrahl)
Attachment #9102821 -
Flags: approval-comm-release?
Attachment #9102821 -
Flags: approval-comm-esr60?
Now with commit message
Attachment #9102821 -
Attachment is obsolete: true
Attachment #9102821 -
Flags: review?(frgrahl)
Attachment #9102821 -
Flags: approval-comm-release?
Attachment #9102821 -
Flags: approval-comm-esr60?
Attachment #9104545 -
Flags: review?(frgrahl)
Attachment #9104545 -
Flags: approval-comm-release?
Attachment #9104545 -
Flags: approval-comm-esr60?
|
||
Comment 3•6 years ago
|
||
Comment on attachment 9104545 [details] [diff] [review]
Remove unused code v1.1
LGTM
Attachment #9104545 -
Flags: review?(frgrahl)
Attachment #9104545 -
Flags: review+
Attachment #9104545 -
Flags: approval-comm-release?
Attachment #9104545 -
Flags: approval-comm-release+
Attachment #9104545 -
Flags: approval-comm-esr60?
Attachment #9104545 -
Flags: approval-comm-esr60+
Pushed by [email protected]:
https://hg.mozilla.org/comm-central/rev/0b8671277850
Remove unused code from commandglue.js. r=frg
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
|
|
||
Comment 5•6 years ago
|
||
status-seamonkey2.49esr:
--- → wontfix
status-seamonkey2.53:
--- → affected
status-seamonkey2.57esr:
--- → fixed
Target Milestone: --- → seamonkey2.69
|
|
||
Comment 6•5 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•