Closed Bug 1576147 Opened 6 years ago Closed 6 years ago

Use async/await for frame processing in pageInfo

Categories

(SeaMonkey :: Page Info, task)

Product:
SeaMonkey
Component:
Page Info
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.49esr wontfix, seamonkey2.53 fixed, seamonkey2.57esr fixed, seamonkey2.63 wontfix)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.68
Tracking Flags:
Tracking Status
seamonkey2.49esr --- wontfix
seamonkey2.53 --- fixed
seamonkey2.57esr --- fixed
seamonkey2.63 --- wontfix

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

(Blocks 1 open bug)

Details

(Whiteboard: SM2.53.1)

Attachments

(1 file, 1 obsolete file)

Switch pageinfo to async/wait v1.1
15.35 KB, patch
frg
: review+
frg
: approval-comm-release+
frg
: approval-comm-esr60+
Details | Diff | Splinter Review

Port the following:

  • Bug 1175794 - Use task with setTimeout and send messages to continuously update PageInfo Media tab
  • Bug 1255773 - Account for multiple media elements per node for Page Info
  • Bug 1353542 - Switch to async/await from Task.jsm/yield
Attached patch Switch pageinfo to async/wait (obsolete) — — Splinter Review

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: Nothing
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): None (more understand of magic required)
String changes made by this patch: None

Attachment #9087707 - Flags: review?(frgrahl)
Attachment #9087707 - Flags: approval-comm-release?
Attachment #9087707 - Flags: approval-comm-esr60?

Remove unused parts that were missed during patch reorganisation.

Attachment #9087707 - Attachment is obsolete: true
Attachment #9087707 - Flags: review?(frgrahl)
Attachment #9087707 - Flags: approval-comm-release?
Attachment #9087707 - Flags: approval-comm-esr60?
Attachment #9092858 - Flags: review?(frgrahl)
Attachment #9092858 - Flags: approval-comm-release?
Attachment #9092858 - Flags: approval-comm-esr60?
Comment on attachment 9092858 [details] [diff] [review] Switch pageinfo to async/wait v1.1 lgtm r/a+
Attachment #9092858 - Flags: review?(frgrahl)
Attachment #9092858 - Flags: review+
Attachment #9092858 - Flags: approval-comm-release?
Attachment #9092858 - Flags: approval-comm-release+
Attachment #9092858 - Flags: approval-comm-esr60?
Attachment #9092858 - Flags: approval-comm-esr60+

Pushed by [email protected]:
https://hg.mozilla.org/comm-central/rev/20fdbeecb553
Use async/await for frame processing in pageInfo. r=frg

Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: SM2.53.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size:

OSZAR »