Closed
Bug 1315911
Opened 8 years ago
Closed 8 years ago
[DateTimePicker] Disable time picker UI by making it pref-off by default
Categories
(Toolkit :: UI Widgets, defect)
Toolkit
UI Widgets
Tracking
()
RESOLVED
FIXED
mozilla52
Tracking | Status | |
---|---|---|
firefox52 | --- | fixed |
People
(Reporter: scottwu, Assigned: scottwu)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
The date picker UI is considered more essential than the time picker UI. Thus we are re-prioritizing our work to focus on the date picker instead. The time picker UI will be disabled by default and can be turned on via pref.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → scwwu
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Attachment #8808880 -
Flags: review?(mconley)
Assignee | ||
Comment 3•8 years ago
|
||
Based on the input from product and UX, it seems that the date picker should be prioritized over the time picker. I will pref off the time picker for now and focus on the date picker instead. Mike, wonder if you could review this small patch?
I created a “dom.forms.datetime.timepicker” pref that defaults to false. When datetimebox is clicked, it checks if type is "time", and if the pref is true or false.
Thanks!
Flags: needinfo?(mconley)
Comment 4•8 years ago
|
||
mozreview-review |
Comment on attachment 8808880 [details]
Bug 1315911 - Disable time picker UI by making it pref-off by default;
https://reviewboard.mozilla.org/r/91602/#review91586
::: toolkit/content/browser-content.js:1678
(Diff revision 2)
> * DOM events.
> */
> handleEvent: function(aEvent) {
> switch (aEvent.type) {
> case "MozOpenDateTimePicker": {
> - if (!(aEvent.originalTarget instanceof content.HTMLInputElement)) {
> + // Time picker is disabled when pref off
"pref" -> "preffed"
Attachment #8808880 -
Flags: review?(mconley) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Comment 6•8 years ago
|
||
Thanks Mike!
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d55d7d48f92cf9a7f15b0ff9e98dd29a23affa00
Flags: needinfo?(mconley)
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/69fd9d1c09c5
Disable time picker UI by making it pref-off by default; r=mconley
Keywords: checkin-needed
Comment 8•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Updated•8 years ago
|
Blocks: datetime-bugs
Updated•8 years ago
|
No longer blocks: datetime-bugs
You need to log in
before you can comment on or make changes to this bug.
Description
•