Closed Bug 1196836 Opened 10 years ago Closed 10 years ago

Remove _get_partial_info() from desktop_l10n.py

Categories

(Release Engineering :: General, defect)

defect
Not set
normal

Tracking

(firefox43 fixed)

RESOLVED FIXED
Tracking Status
firefox43 --- fixed

People

(Reporter: rail, Assigned: rail)

References

Details

Attachments

(1 file)

No more partials!
Attachment #8656610 - Flags: review?(jlund)
Comment on attachment 8656610 [details] [diff] [review] no_more_partials-mozharness.diff Review of attachment 8656610 [details] [diff] [review]: ----------------------------------------------------------------- exciting! I'm guessing the release bits (single_locale, bouncer) will need to keep partial code while this rides trains?
Attachment #8656610 - Flags: review?(jlund) → review+
We still need partials for Bouncer - that is used by release builds. But partial_mar can be deleted from single_locale configs for sure.
okay, tracking here the two further places we could bring out the axe for 1) <jlund> rail: so I wonder if we can delete https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/mozharness/mozilla/building/buildbase.py#1492 and https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/mozharness/mozilla/building/buildbase.py#98 if desktop and desktop_l10n are not doing partials anymore then. <rail> jlund: I think so... I'd ask mshal first, the "TC" suffix makes me not 100% sure 2) partial_mar can be deleted from single_locale configs
Flags: needinfo?(mshal)
(In reply to Jordan Lund (:jlund) from comment #4) > okay, tracking here the two further places we could bring out the axe for > > 1) > > <jlund> rail: so I wonder if we can delete > https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/mozharness/ > mozilla/building/buildbase.py#1492 and > https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/mozharness/ > mozilla/building/buildbase.py#98 if desktop and desktop_l10n are not doing > partials anymore then. > <rail> jlund: I think so... I'd ask mshal first, the "TC" suffix makes me > not 100% sure That should be fine to go - the TC suffix ones aren't actually used anywhere. We just added that because we still wanted to submit completes/partials with FTP URLs instead of TC URLs.
Flags: needinfo?(mshal)
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size:

OSZAR »