Which ones should be disabled?

Chris, The builds to be disabled is as attach patch. We'd also like to update test from linux to linux64. Would you review this patch? Thanks!

Comment on attachment 8592859 [details] [diff] [review] bug-1154362.patch I verified it with test-masters.sh, it is passed.

Comment on attachment 8592859 [details] [diff] [review] bug-1154362.patch Review of attachment 8592859 [details] [diff] [review]: ----------------------------------------------------------------- can you disable the tests as well? Run 'tox' to run all the test suites for buildbot-configs, and you can see that your patch leaves tests around with no corresponding builds.

Catlee, with my patch 'tox' is also passed. Please see the attach file. I simply run 'tox' without any parameters, is it correct? Thanks!

It looks like it's failing the 'py27' tests: ERROR: py27: could not install deps [Jinja2==2.5.5, MozillaPulse==0.80, MySQL-python==1.2.3, SQLAlchemy==0.6.4, Twisted==10.1.0, amqplib==0.6.1, anyjson==0.3, argparse==1.1, carrot==0.10.7, distribute==0.6.14, mozci==0.4.1, pyOpenSSL==0.14, pyasn1==0.0.11a, pycrypto==2.3, pytest==2.7.0, pytz==2011d, wsgiref==0.1.2, zope.interface==3.6.1]; v = InvocationError('/home/kaizhen/Buildbot/buildbot-configs/.tox/py27/bin/pip install Jinja2==2.5.5 MozillaPulse==0.80 MySQL-python==1.2.3 SQLAlchemy==0.6.4 Twisted==10.1.0 amqplib==0.6.1 anyjson==0.3 argparse==1.1 carrot==0.10.7 distribute==0.6.14 mozci==0.4.1 pyOpenSSL==0.14 pyasn1==0.0.11a pycrypto==2.3 pytest==2.7.0 pytz==2011d wsgiref==0.1.2 zope.interface==3.6.1 (see /home/kaizhen/Buildbot/buildbot-configs/.tox/py27/log/py27-1.log)', 1) If you don't want mysql locally, you can remove MySQL-python from master-pip.txt and try again. To test just this environment, you can run 'tox -e py27'

Chris, Thanks! Now I can verify my patch with tox, and this patch is verified passed. We'd like to keep the testing and just remove some unnecessary builds. Would you review this patch?

In production: https://hg.mozilla.org/build/buildbot-configs/rev/eacd5a35961d

Build and test on v2.1s seem more than the project need. Going to disable more. https://treeherder.mozilla.org/#/jobs?repo=mozilla-b2g34_v2_1s

Catlee, As comment 10, more build and tests should be disabled. Would you mind review this patch? Thanks!

Comment on attachment 8615840 [details] [diff] [review] bug-1154362-2.patch Review of attachment 8615840 [details] [diff] [review]: ----------------------------------------------------------------- looks ok to me

Vincent, there's a bit of confusion here about what builds/tests Kai-Zhen was trying to turn off. The patch he posted would turn off *tests* (but not builds) for B2G emulator/desktop builds. It wouldn't have any affect on the desktop Firefox builds/tests that run on v2.1s. That doesn't seem right :) The impression I get from comment 10 was that the intent was to turn off desktop Firefox builds/tests on v2.1s and leave the B2G stuff alone. Does that make sense to you?

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #13) > Vincent, there's a bit of confusion here about what builds/tests Kai-Zhen > was trying to turn off. The patch he posted would turn off *tests* (but not > builds) for B2G emulator/desktop builds. It wouldn't have any affect on the > desktop Firefox builds/tests that run on v2.1s. That doesn't seem right :) > > The impression I get from comment 10 was that the intent was to turn off > desktop Firefox builds/tests on v2.1s and leave the B2G stuff alone. Does > that make sense to you? v2.1s is dedicated for dolphin device, so that's why Kai-Zhen disabled these *tests* for B2G emulator/desktop builds. I also think it is a better way to do this. :)

Would you be happy if only Dolphin builds ran and nothing else?

I agree with comment 13, keep some test dedicated for b2g is a better choice, but the test result need to be monitored and handled accordingly. The idea of patch-2 is if no one care about the test result or have no plan to fix them it could be better to disable them which could also save some build/test resources. BTW, bug-1154362-2.patch is not landed, we can submit a new patch to replace it depends on when we want to keep on v2.1s.

(In reply to Kai-Zhen Li [:kli][:seinlin] from comment #16) > I agree with comment 13, keep some test dedicated for b2g is a better > choice, but the test result need to be monitored and handled accordingly. Yeah, I think that if we're choosing between Fx desktop tests and B2G tests, the choice is a pretty obvious one :) > The idea of patch-2 is if no one care about the test result or have no plan > to fix them it could be better to disable them which could also save some > build/test resources. Amen to that! Who needs to commit to that? > BTW, bug-1154362-2.patch is not landed, we can submit a new patch to replace > it depends on when we want to keep on v2.1s. I'm happy to work up the revised patch depending on what is decided. I'm already patching things in a similar area for turning off some other builds/tests on b2g32/b2g34.

Comment on attachment 8615840 [details] [diff] [review] bug-1154362-2.patch Based on the discussion here, I think it makes the most sense to kill the Fx desktop builds and leave the B2G stuff alone for now.

Ryan, Thanks for working on this.

I am sorry that I can't continue to work on this.