Closed
Bug 1118796
Opened 10 years ago
Closed 10 years ago
Set up project branch to create beta builds on checkin
Categories
(Release Engineering :: Release Automation, defect)
Release Engineering
Release Automation
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: catlee, Assigned: nthomas)
References
Details
Attachments
(2 files)
1.76 KB,
patch
|
rail
:
review+
nthomas
:
checked-in+
|
Details | Diff | Splinter Review |
2.66 KB,
patch
|
bhearsum
:
review+
nthomas
:
checked-in+
|
Details | Diff | Splinter Review |
Use a disposable branch to produce builds with full beta branding, mozconfig options, "pretty naming", beta signing keys, etc. Run those builds when code lands in the repo, and ensure tests are triggered. For comparison of test results, it may be helpful to run the beta builds in parallel with existing builds. Complete mar files should created for each build but not partials. XULRunner SDKs will happen here too.
Assignee | ||
Comment 1•10 years ago
|
||
Grabbed Date for this, bug 1089701 to recreate the repo after the merge.
Status: NEW → ASSIGNED
Depends on: 1089701
Assignee | ||
Comment 2•10 years ago
|
||
This will get me the same set of builders and testers as mozilla-beta has, but using mozharness for builds. Will still uses the dep certs, and doesn't actually do pgo, but I'll get those later.
Attachment #8553320 -
Flags: review?(rail)
Comment 3•10 years ago
|
||
Comment on attachment 8553320 [details] [diff] [review]
[buildbot-configs] Date setup 1.0
woooooo!!!!
Attachment #8553320 -
Flags: review?(rail) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8553320 [details] [diff] [review]
[buildbot-configs] Date setup 1.0
https://hg.mozilla.org/build/buildbot-configs/rev/3bfb8518160f
Attachment #8553320 -
Flags: checked-in+
Comment 5•10 years ago
|
||
buildbot-config patch(es) are live in production
Assignee | ||
Comment 6•10 years ago
|
||
First builds - https://treeherder.mozilla.org/#/jobs?repo=date&revision=1d3c24b896a1
Green:
* talos and webplatform on all platforms except mac, which fails to encode spaces into %20 in urls (dmg+crash symbols, also tests.zip but not needed for talos). win32 unexpectedly works, because it uses the .zip file which doesn't have pretty naming; neither does the crashreporter symbols
* everything on win64 except JP, because it doesn't use pretty naming
Failing:
* mochitest/reftest/crashtest/etc - incorrectly computing jsshell url, eg http://ftp.mozilla.org.proxxy1.srv.releng.usw2.mozilla.com/pub/mozilla.org/firefox/tinderbox-builds/date-linux/1422324743/jsshell-0.zip, which should end jsshell-linux-i686.zip. We're passing in pretty named files which don't contain a platform, and query_jsshell_url() at http://hg.mozilla.org/build/mozharness/file/ccc3f9f479d4/mozharness/mozilla/testing/testbase.py#l120 relies on it being present.
Reporter | ||
Comment 7•10 years ago
|
||
\o/
do these tests require the jsshell, or can we ignore this here?
Assignee | ||
Comment 8•10 years ago
|
||
I tried turning off the jsshell download, and it turns out only jittest needs it. The other mochitests went green.
Assignee | ||
Comment 9•10 years ago
|
||
https://hg.mozilla.org/build/buildbot-configs/rev/c6ae16127e65 bumps the gecko version to 37 on date.
Assignee | ||
Comment 10•10 years ago
|
||
We reverted to using non-pretty names, and will rename files between them being produced and being stashed in the candidates directory. This implies some munging off checksums files and resigning.
Complete mar files are happening in each build, although they don't show up in tinderbox-builds because post_upload.py drops them. They do end up in TC as artifacts.
SDK files are being produced and uploaded after porting bug 1137000, with some tweaks.
At this point I need to sort through the patches and figure out what can land, and what remains in date only.
Assignee | ||
Comment 11•10 years ago
|
||
One thing of note - current release builds clobber the working directory at the top of every job, while on-push builds do not. We could clobber every depend build on every beta/release and put up with the performance hit, or drop that requirement. Since speed is the point of moving to promotion it deserves serious consideration, but I'm planning that we do that as a followup.
Assignee | ||
Comment 12•10 years ago
|
||
Bringing over a little of my setup from a user repo
* sets the mozconfig for on-push builds to be the on used for release builds on the beta branch
* sets ENABLE_RELEASE_PROMOTION in en-US builds, which changes some variables in mozconfigs to follow (uploading symbols and creating the SDK in each build)
Attachment #8585407 -
Flags: review?(bhearsum)
Assignee | ||
Updated•10 years ago
|
Attachment #8553320 -
Attachment description: [buildbot-configs] Date setep 1.0 → [buildbot-configs] Date setup 1.0
Assignee | ||
Updated•10 years ago
|
Attachment #8585407 -
Attachment description: [mozharness] → [mozharness] Setup 2
Comment 13•10 years ago
|
||
(In reply to Nick Thomas [:nthomas] from comment #11)
> One thing of note - current release builds clobber the working directory at
> the top of every job, while on-push builds do not. We could clobber every
> depend build on every beta/release and put up with the performance hit, or
> drop that requirement. Since speed is the point of moving to promotion it
> deserves serious consideration, but I'm planning that we do that as a
> followup.
I honestly can't remember why we clobber. I know we used use -j1 for release builds because we were paranoid about ||ization doing something bad, and this feels like it's in a similar vein. Personally, I'd be okay getting rid of it. We can always add it back in if we realize it's important later...
Comment 14•10 years ago
|
||
Comment on attachment 8585407 [details] [diff] [review]
[mozharness] Setup 2
Review of attachment 8585407 [details] [diff] [review]:
-----------------------------------------------------------------
::: configs/builds/branch_specifics.py
@@ +114,5 @@
> + 'date': {
> + 'enable_release_promotion': 1,
> + 'platform_overrides': {
> + 'linux': {
> + 'src_mozconfig': 'browser/config/mozconfigs/linux32/beta',
Once release promotion is the only supported way to build on branches like this it may be better to just change the "nightly" mozconfigs rather than maintain separate names. I wonder how much of the contents of release style mozconfigs we want to bring all the way back to opt builds on central/aurora, too. This certainly seems like the best thing for now while we need to support both styles.
Sidenote: This made me think that mozconfig comparison tests will be going away in a build promotion world...I hope I'm right about that!
Attachment #8585407 -
Flags: review?(bhearsum) → review+
Assignee | ||
Comment 15•10 years ago
|
||
Comment on attachment 8585407 [details] [diff] [review]
[mozharness] Setup 2
https://hg.mozilla.org/build/mozharness/rev/2dd0966af501
Attachment #8585407 -
Flags: checked-in+
Assignee | ||
Comment 16•10 years ago
|
||
(In reply to Ben Hearsum [:bhearsum] from comment #14)
> Once release promotion is the only supported way to build on branches like
> this it may be better to just change the "nightly" mozconfigs rather than
> maintain separate names. I wonder how much of the contents of release style
> mozconfigs we want to bring all the way back to opt builds on
> central/aurora, too. This certainly seems like the best thing for now while
> we need to support both styles.
>
> Sidenote: This made me think that mozconfig comparison tests will be going
> away in a build promotion world...I hope I'm right about that!
Possibly. I think we'll want a slightly different kind of promotion on nightly+aurora, eg dep builds to nightlies. There will probably be some branding differences, but maybe those are in confvars.sh and handled at merge time. Getting rid of the mozconfig comparisons would be great.
Comment 17•10 years ago
|
||
mozharness production tag moved to: https://hg.mozilla.org/build/mozharness/rev/production
Assignee | ||
Comment 18•10 years ago
|
||
Date is up and running, with the following caveats
* complete.mar files aren't on ftp, but are in taskcluster
* population of the candidates dir/bucket will be done separately, it's closely related to the netapp -> S3 project in Q2
* the patches for complete mar and sdk need to be extracted and landed on m-c/m-a/m-b if they can be made safe, see bug 649485 and bug 1142231
Comment 19•10 years ago
|
||
Is this done and/or superceded by bug 1178324?
Assignee | ||
Comment 20•10 years ago
|
||
Superceded, lets say this was the initial setup work.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•