+++ This bug was initially created as a clone of Bug #990047 +++ We can replace the custom code used to load JSON file here with the new shared helper: https://github.com/mozilla-b2g/gaia/blob/5c527dcf07499f1b6a055d40595642f101efb418/apps/wallpaper/js/pick.js#L26

I did 3 thing. 1. Updated the pick.js file to the lazy_loader json method. 2. Included the Lazy_Loader in the pick.html else we would get undefined object. 3. Included Lazy_Loader in the unit test file as need it to test ! Thanks !

Comment on attachment 8490382 [details] [review] Pull request from Github about the conversion to LazyLoader for Pick.js. Thanks for your work here, just a quick note before the review: I can only give you feedback here since I'm not a peer of the wallpaper app. You will need to ask for review to a peer, check the suggested reviewers or the commit log to see who'd be available. That being said the changes you made are logical and seem to work fine however there's a couple of issues you need to address: - In your first commit you've re-indented the whole pick.js file, you should revert it and add only your changes leaving the indentation of the rest of the code as it was. - Squash all your commits into one, we use multiple patches only in cases were we're doing major work and we've got no other choice. All other changes should be done within a single patch. Ask me for feedback again once you've updated your PR.

Hi, I squashed all my commits into one. Rolled back the old indentation stuff so my patch only contains my changes. Re-ran the unit test and lint to make sure I didn't broke anything. Thanks for the feedback.

Comment on attachment 8490930 [details] [review] PR From Github, with the changes from view applied. The patch logic is generally good but there's still a few stylistic issues to address; I've left the comments on the PR on GitHub.

Hi, I applied the following changes. 1. Re Indent the code to 2 space instead of 4 (Hope I got it right this time :) ). 2. Moved the variable declaration for both func and sub func at the top. Thanks for looking into it !

Comment on attachment 8491316 [details] [review] PR From Github, with the styling issues fixed. Looks good to me with only one final nit, comment on the PR.

Great ! I applied the nit comment to the PR. Thanks again for guiding me through the styling stuff. (In reply to Gabriele Svelto [:gsvelto] from comment #6) > Comment on attachment 8491316 [details] [review] > PR From Github, with the styling issues fixed. > > Looks good to me with only one final nit, comment on the PR.

Comment on attachment 8491316 [details] [review] PR From Github, with the styling issues fixed. that looks good to me. generally the pull request should be reviewed by owner or peer but since this is a minor fix, I would give r+ to it. next time please find the owner/peer to review your patch :D https://wiki.mozilla.org/Modules/FirefoxOS

we got a red Gij, re-run again: https://tbpl.mozilla.org/?rev=2e0be2fd941a78cd65da86ea5a799518bf99daca&tree=Gaia-Try I will merge it if we get green Gij later.

Yuren, the wallpaper app was not on the Modules page... last week :) I'm glad it was added then ;)

Hi, I reran the whole try. And... it worked all green :). https://tbpl.mozilla.org/?rev=de9f4f9507811f548ac48e233f5c642e2825c664&tree=Gaia-Try (In reply to Yuren [:yurenju] (last day: 9/26) from comment #9) > we got a red Gij, re-run again: > > https://tbpl.mozilla.org/ > ?rev=2e0be2fd941a78cd65da86ea5a799518bf99daca&tree=Gaia-Try > > I will merge it if we get green Gij later.

cool, merged! https://github.com/mozilla-b2g/gaia/commit/a88441250f04836401f524fead6bc3b686dcb0e5