WeakSet.prototype is just an ordinary object.

Apparently there are some tests in dom/ for weakmaps?! https://treeherder.mozilla.org/#/jobs?repo=try&revision=d92ca6857564 The test is not wrong, but we don't yet have WeakMap.prototype.@@toStringTag.

Dup of bug 656828, except: - 656828 also changes Map and Debugger - patches in 656828 are most likely out of date.

Comment on attachment 8600686 [details] [diff] [review] Make WeakMap/Set.prototype a plain object Review of attachment 8600686 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/imptests/failures/html/js/builtins/test_WeakMap.prototype-properties.html.json @@ +3,5 @@ > "WeakMap.prototype.delete.length": true, > "WeakMap.prototype.get.length": true, > "WeakMap.prototype.has.length": true, > + "WeakMap.prototype.set.length": true, > + "WeakMap.prototype.@@toStringTag": true ...it's really necessary to *opt IN* to every test you want to run, and not to opt *out* of every test you fail? Sadfaces.

(In reply to Jeff Walden [:Waldo] (remove +bmo to email) from comment #5) > Comment on attachment 8600686 [details] [diff] [review] > Make WeakMap/Set.prototype a plain object > > Review of attachment 8600686 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: > dom/imptests/failures/html/js/builtins/test_WeakMap.prototype-properties. > html.json > @@ +3,5 @@ > > "WeakMap.prototype.delete.length": true, > > "WeakMap.prototype.get.length": true, > > "WeakMap.prototype.has.length": true, > > + "WeakMap.prototype.set.length": true, > > + "WeakMap.prototype.@@toStringTag": true > > ...it's really necessary to *opt IN* to every test you want to run, and not > to opt *out* of every test you fail? Sadfaces. Well actually that's all the tests that are known to fail. I think all of the "length" tests fail, because we changed the property to be configurable. @@toStringTag fails now, because Object.toString.call(WeakMap.prototype) would return "[object WeakMap] if we had @@toStringTag.

https://hg.mozilla.org/mozilla-central/rev/0536b35fa2fa https://hg.mozilla.org/mozilla-central/rev/352218aee262

https://developer.mozilla.org/en-US/Firefox/Releases/40 https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WeakMap/prototype https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WeakSet/prototype